Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds changelog for apama-in-c8y-20241104-Fixed-a-potential-deadlock #2602

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Adds changelog for apama-in-c8y-20241104-Fixed-a-potential-deadlock #2602

merged 3 commits into from
Nov 5, 2024

Conversation

jato-c8y
Copy link
Contributor

@jato-c8y jato-c8y commented Nov 4, 2024

For PAM-35075.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Preview available here

@jato-c8y jato-c8y marked this pull request as ready for review November 5, 2024 10:24
@jato-c8y jato-c8y marked this pull request as draft November 5, 2024 10:24
skom-c8y
skom-c8y approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@skom-c8y skom-c8y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please mark the PR as ready

@jato-c8y jato-c8y marked this pull request as ready for review November 5, 2024 11:58
@jato-c8y @kailol-sag
Update content/change-logs/analytics/apama-in-c8y-20241104-Fixed-a-po…
c0e0a1f 
…tential-deadlock-when-a-large-number-of-requests-are-waiting-to-be-flushed.md

Co-authored-by: Karin Olivier <[email protected]>
@jato-c8y jato-c8y merged commit f97f369 into develop Nov 5, 2024
3 checks passed
@jato-c8y jato-c8y deleted the PAM-35075 branch November 5, 2024 14:07
@github-actions github-actions bot mentioned this pull request Nov 5, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

💚 All backports created successfully

Status Branch Result
✅ release/y2024

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@kailol-sag
Copy link
Contributor

@jato-c8y and @skom-c8y , was it really intended to merge this already? A deploy date has not yet been added ... ????

@jato-c8y
Copy link
Contributor Author

jato-c8y commented Nov 5, 2024

@jato-c8y and @skom-c8y , was it really intended to merge this already? A deploy date has not yet been added ... ????

Potentially my mistake, I assumed the approval meant it was ok to merge

@kailol-sag
Copy link
Contributor

kailol-sag commented Nov 5, 2024 •
edited
Loading

Potentially my mistake, I assumed the approval meant it was ok to merge

It's normally Sandeep who merges the doc PRs on the deployment date, and he also adds the date then.
If you need some background info, see https://cumulocity.atlassian.net/wiki/spaces/apama/pages/28263242/PAQ+change+logs+and+user+documentation

@jato-c8y jato-c8y mentioned this pull request Nov 5, 2024
Closed
@jato-c8y
Copy link
Contributor Author

jato-c8y commented Nov 5, 2024 •
edited
Loading

thanks @kailol-sag created revert.
Revert was not required instead a dummy PR is created until a known date can be added

@jato-c8y jato-c8y restored the PAM-35075 branch November 5, 2024 14:51
@jato-c8y jato-c8y deleted the PAM-35075 branch November 6, 2024 12:43
@jato-c8y jato-c8y mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bph-c8y bph-c8y bph-c8y left review comments

@Rob-J-SAG Rob-J-SAG Rob-J-SAG approved these changes

@skom-c8y skom-c8y skom-c8y approved these changes

@kailol-sag kailol-sag kailol-sag approved these changes

@BeateRixen BeateRixen Awaiting requested review from BeateRixen BeateRixen is a code owner

@MWindel MWindel Awaiting requested review from MWindel

Assignees
No one assigned
Labels
auto-backport auto-backport-to-release/y2024 streaming-analytics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jato-c8y @kailol-sag @skom-c8y @bph-c8y @Rob-J-SAG